Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes to make serial run on Linux:
A couple choices I made that I would like a confirmation on, but seemed reasonable:
/dev/tty
as the non-Windows prefix. This is apparently not entirely universal, e.g. see here, but the exceptions listed are all BSDs./dev/
would catch all those, but also/dev/video*
and so webcam hardware would get caught in that too. (I checked, it can capture e.g. the Index cameras, as long as thehttp
prefixing is bypassed for that.) One option if you wanna allow for the cases where auto-detection fails could be to add a toggle or dropdown next to the input box, maybe with a default "auto-detect" that detects most cases. However, I figured I'd improve over the current situation and leave anything further to your discretion.Checklist