-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/etvr module support #106
Open
lorow
wants to merge
35
commits into
EyeTrackVR:v2.0-beta-feature-branch
Choose a base branch
from
lorow:feature/etvr-module-support
base: v2.0-beta-feature-branch
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/etvr module support #106
lorow
wants to merge
35
commits into
EyeTrackVR:v2.0-beta-feature-branch
from
lorow:feature/etvr-module-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorow
changed the title
DRAFTL Feature/etvr module support
DRAFT Feature/etvr module support
Mar 20, 2024
lorow
force-pushed
the
feature/etvr-module-support
branch
from
March 23, 2024 21:09
598052a
to
d61e8b9
Compare
# TODO: # - there's ghosts in the machine - vrc osc is not working properly # - pysimple gui - fix descriptions # - min/maxing will require field combinators in the modules lmao
# TODO: # - there's ghosts in the machine - vrc osc is not working properly # - min/maxing will require field combinators in the modules lmao
# TODO: # - there's ghosts in the machine - vrc osc is not working properly # - min/maxing will require field combinators in the modules lmao
# TODO: # - there's ghosts in the machine - vrc osc is not working properly # - min/maxing will require field combinators in the modules lmao
# TODO: # - there's ghosts in the machine - vrc osc is not working properly # - min/maxing will require field combinators in the modules lmao
# TODO: # - there's ghosts in the machine - vrc osc is not working properly # - min/maxing will require field combinators in the modules lmao
# TODO: # - there's ghosts in the machine - vrc osc is not working properly # - min/maxing will require field combinators in the modules lmao
NOTE: I brought back the entire old OSC implementation as a live reference, this will be removed once I'm done. This also lays ground for other modes as they're pretty similar # TODO: # - there's ghosts in the machine - vrc osc is not working properly # - min/maxing will require field combinators in the modules lmao
# TODO: # - min/maxing will require field combinators in the modules lmao
# TODO: # - min/maxing will require field combinators in the modules lmao
# TODO: # - min/maxing will require field combinators in the modules lmao
# TODO: # - min/maxing will require field combinators in the modules lmao
# TODO: # - min/maxing will require field combinators in the modules lmao
…ig sends everything changed anyway, sunset the idea of using single client and thus simplify the code a bit # TODO: # - min/maxing will require field combinators in the modules lmao
# TODO: # - min/maxing will require field combinators in the modules lmao
# TODO: # - min/maxing will require field combinators in the modules lmao
lorow
force-pushed
the
feature/etvr-module-support
branch
from
March 29, 2024 19:41
77e2331
to
a0b8b3f
Compare
# TODO: # - min/maxing will require field combinators in the modules lmao
# TODO: # - min/maxing will require field combinators in the modules lmao
…Receiver # TODO: # - min/maxing will require field combinators in the modules lmao
lorow
force-pushed
the
feature/etvr-module-support
branch
from
April 15, 2024 20:38
b0641b0
to
1e6fced
Compare
… feature/etvr-module-support # Conflicts: # EyeTrackApp/enums.py # EyeTrackApp/osc.py # EyeTrackApp/settings/algo_settings_widget.py
… feature/etvr-module-support # Conflicts: # EyeTrackApp/ellipse_based_pupil_dilation.py # EyeTrackApp/utils/misc_utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors completely OSC and adds support for the VRCFT module
Checklist