Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX of rotated crop #100

Open
wants to merge 11 commits into
base: v2.0-beta-feature-branch
Choose a base branch
from

Conversation

SafariMonkey
Copy link

Description

  • ROI region is cropped at the same time as rotation, not before, so the crop doesn't cut into the rotated ROI
    • Filling the background is skipped if the crop is entirely within the camera image, and the image is warped with transparency enabled and then filled based on the average colors of non-transparent pixels otherwise.
  • Make ROI widget rotate the image, optionally with padding so the widget stays the same size as it rotates
    • The crop is limited to the axis-aligned bounding box (AABB) of the image corners, to make it easier to not waste any rows or columns.
  • Add a crosshair to the ROI widget (with some slightly sneaky access of the underlying tkinter to set the dashed line property)

Checklist

  • I accept the CLA.

@SafariMonkey SafariMonkey changed the title Improve UX of rotated crop Draft: Improve UX of rotated crop Nov 7, 2023
@SafariMonkey SafariMonkey changed the title Draft: Improve UX of rotated crop Improve UX of rotated crop Nov 8, 2023
@RedHawk989 RedHawk989 self-requested a review November 11, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant