Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force scale=1 to avoid clipped screenshots #7

Merged
merged 1 commit into from Sep 3, 2020
Merged

Conversation

tokland
Copy link

@tokland tokland commented Aug 31, 2020

@SferaDev
Copy link

SferaDev commented Sep 3, 2020

Tested on metadata-sync and windows 10, everything works as expected and better than before.

LGTM

@adrianq
Copy link
Member

adrianq commented Sep 3, 2020

@tokland Can you please bring this change into metadata sync as well? You can just add it to the PR you are already preparing. @SferaDev Correct me if I am wrong but I didn't see this change as part of any of your PR, right?

@adrianq
Copy link
Member

adrianq commented Sep 3, 2020

@tokland Btw I am accepting this but I guess you should create a PR in Project Monitoring, right? (Do not forget about my previous comment as well)

@adrianq adrianq marked this pull request as ready for review September 3, 2020 22:14
@adrianq adrianq merged commit 64b8da1 into development Sep 3, 2020
@SferaDev
Copy link

SferaDev commented Sep 4, 2020

@tokland Can you please bring this change into metadata sync as well? You can just add it to the PR you are already preparing. @SferaDev Correct me if I am wrong but I didn't see this change as part of any of your PR, right?

Yeah we tested this together with tokland as part of a meeting yesterday but didn't commit it to any open PR.

@tokland
Copy link
Author

tokland commented Sep 4, 2020

Uploaded to those open PRs:

project-monitoring-app: EyeSeeTea/data-management-app#303
metadata-synchronization: EyeSeeTea/metadata-synchronization#617

@tokland
Copy link
Author

tokland commented Sep 4, 2020

As a note. SVGs are not being rendered on the screenshot. Apparently, this ticket solved it, but we'd need to add more js code to the mix. The tools is big enough, I don't think it's a big gain to see those buttons.

niklasvh/html2canvas#95

@adrianq
Copy link
Member

adrianq commented Sep 4, 2020

Thanks guys! I agree is not a big change to have SVGs rendered properly. My main concern atm and, in particular, for project monitoring is to be able to capture iframe but this is a battle for another life ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants