Add ESP32 S3 lr1121 targets #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for upcoming lr1121 s3 based targets
pkendall64
reviewed
May 6, 2024
pkendall64
reviewed
May 6, 2024
|
Flashed a rx for testing with no problems. Will you be adding some DIY/Generic targets to https://github.com/ExpressLRS/targets? If you do please follow the pin out of the other S3 devkit targets. |
|
My current board is off the shelf devkit and the pins are all over the place, some DIY targets + matching hardware that does what everything else uses would make sense. |
|
NP, Ill get something up thats similar to the current targets. |
|
@radio-mistress Can you resolve the conflict and we can get this tested and merged |
|
now contains C3 and S3 I can't test the C3 stuff but S3 is still working |
pkendall64
approved these changes
May 19, 2024
JyeSmith
approved these changes
May 21, 2024
mha1
pushed a commit
to mha1/ExpressLRS
that referenced
this pull request
May 21, 2024
* add esp32 s3 lr1121 targets for upcoming lr1121 s3 based targets * Removed extra flags * put the flags needed to build back * Updated with esp32-C3 targets * remove duplicate entries from jank online github merge --------- Co-authored-by: Jye <14170229+JyeSmith@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for both RX and TX, tested with esp32 feather S3.