Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

177-qFit to work for EM with appropriate SF #322

Merged
merged 49 commits into from
May 5, 2023

Conversation

stephaniewankowicz
Copy link
Collaborator

@stephaniewankowicz stephaniewankowicz commented Mar 31, 2023

Pull Request Checklist

  • Will your PR merge into the dev branch?
    Exceptions will be made for urgent bugfixes.
  • Have you forked from dev?
    If not, please rebase your PR onto the most recent dev tip.
  • Does your PR title succinctly describe the changes?
    Explain to a new user by completing the sentence: 'This PR will: ...'
  • Fill out the template below.

This is a significant change to how we handle EM maps.

  1. We are now using electron SF. The electron SF is only 5 'rings' while X-ray is 6. Therefore in the transformer code, we now flag if it is EM which changes some of the calculations.
  2. We got rid of scattering as this is now folded into EM
  3. With EM, we have a base cardinality of 3 rather than 5.
  4. We remove the bulk solvent masking as done in X-ray as most EM maps do not have a 'bulk solvent' region. This may change in the future.

There will likely need to be updated over the next 2 years as more details and metrics emerge about how EM maps are handled.

Description of the Change

Release Notes


@stephaniewankowicz stephaniewankowicz changed the title 177-Fixing qFit to work for EM 177-qFit to work for EM with appropriate SF May 5, 2023
@stephaniewankowicz stephaniewankowicz merged commit b550fef into dev May 5, 2023
6 checks passed
@stephaniewankowicz stephaniewankowicz deleted the 177--electron-scattering branch May 5, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant