SOF-7354: show labels with atomic symbols when present #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timurbazhirov
approved these changes
May 8, 2024
src/mixins/labels.js
Outdated
| @@ -111,7 +111,7 @@ export const LabelsMixin = (superclass) => | |||
|
|
|||
| group.children.forEach((atom) => { | |||
| if (atom instanceof THREE.Mesh) { | |||
| const text = atom.name.split("-")[0]; | |||
| const text = atom.nameWithLabel; | |||
There was a problem hiding this comment.
Let's see if we can add a tests as well
+ add note on MESA glx error in Ubuntu 24.04
seems currently generated roate and repetitions snapshots are incorrect
otherwise, atomic labels become undefined when cell repetition is enabled
| // set glow according to the labels, currently only single digit | ||
| // numeric labels are allowed, in practice we expect only two | ||
| // different labels: 1 and 2 for up and down spin representations | ||
| const atomColor = this.getAtomColorByElement(element).toLowerCase(); |
There was a problem hiding this comment.
Let's isolate the code that sets glow to a separate function and import from utils. Maybe even put to cove.js or another library
| basis.coordinates.forEach((atomicCoordinate, atomicIndex) => { | ||
| const element = basis.getElementByIndex(atomicIndex); | ||
| const sphereMesh = this.getSphereMeshObject({ | ||
| ...this._getDefaultSettingsForElement(element, atomRadiiScale), | ||
| coordinate: atomicCoordinate.value, | ||
| }); | ||
| sphereMesh.name = `${element}-${atomicIndex}`; | ||
| sphereMesh.userData = { | ||
| ...sphereMesh.userData, |
There was a problem hiding this comment.
Did you just come up with this userData concept or was it used before?
Maybe metadata would be a better name - is there really data that comes from user here??
There was a problem hiding this comment.
No, this is THREE.js in-build field to store custom data https://threejs.org/docs/#api/en/core/Object3D.userData. If we create our own data fields (e.g., metadata), I think it will be stripped while cloning THREE objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.