Fix/sof-6587 #16
Merged
Fix/sof-6587 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azech-hqs
reviewed
Aug 22, 2023
Comment on lines
102
to
106
| case 'backspace': | ||
|
|
||
| event.preventDefault(); // prevent browser back | ||
| // event.preventDefault(); // prevent browser back -- this is no longer an issue since 2016 | ||
|
|
||
| // fall-through |
There was a problem hiding this comment.
If we're not using this case, can it be removed then?
There was a problem hiding this comment.
That was my first idea. But then I thought what if somebody does use this. I tried to remove all event listeners on modal close -- to no avail.
timurbazhirov
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backspace default behavior of deleting stuff was blocked by event listeners added to whole document, I changed addition of them only to the threejs-editor, thus limiting their scope.