Skip to content

Commit

Permalink
Merge pull request #14 from Exabyte-io/update/SOF-6665
Browse files Browse the repository at this point in the history
SOF-6665: CodeMirror without linter
  • Loading branch information
timurbazhirov committed Jun 22, 2023
2 parents 5d24291 + 49a4564 commit dbeb451
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 10 deletions.
7 changes: 3 additions & 4 deletions editor/js/Codemirror.js
@@ -1,11 +1,11 @@
import { basicSetup } from 'codemirror';
import { EditorView, keymap } from '@codemirror/view';
import { javascript, esLint } from '@codemirror/lang-javascript';
import { javascript } from '@codemirror/lang-javascript';
import { EditorState } from '@codemirror/state';
import { oneDark } from '@codemirror/theme-one-dark';
import { lintGutter, linter } from '@codemirror/lint';
//NOTE: aren't importing `Linter` here b/c eslint-prebuilt package is 1.5MB in webapp bundle
import { lintGutter } from '@codemirror/lint';
import { indentWithTab } from '@codemirror/commands';
import Linter from 'eslint4b-prebuilt';

const doc = '';
export const Codemirror = ( { container, extensions = [], ...other } ) => {
Expand All @@ -18,7 +18,6 @@ export const Codemirror = ( { container, extensions = [], ...other } ) => {
javascript(),
oneDark,
keymap.of( [ indentWithTab ] ),
linter( esLint( new Linter() ) ),
lintGutter(),
...extensions
]
Expand Down
5 changes: 0 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Expand Up @@ -152,7 +152,6 @@
"@codemirror/view": "^6.2.1",
"acorn": "1.0.1",
"codemirror": "^6.0.1",
"eslint4b-prebuilt": "^6.7.2",
"esprima": "^3.1.3",
"signals": "1.0.0"
},
Expand Down

0 comments on commit dbeb451

Please sign in to comment.