Update/SOF-7291 add enum #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class IframeToFromHostMessageHandler { | ||
| private handlers: HandlersMap = { "get-data": [], "set-data": [], info: [] }; | ||
| private handlers: HandlersMap = { | ||
| [ActionEnum.GetData]: [], |
There was a problem hiding this comment.
Let's use lowercase first letter and use enums from the IframeMessageSchema
k0stik
reviewed
Apr 8, 2024
| @@ -1,6 +1,11 @@ | |||
| import { Action as ActionEnum, Type as TypeEnum, } from "@mat3ra/esse/dist/js/types"; | |||
There was a problem hiding this comment.
You can not import *.ts in *.js file
There was a problem hiding this comment.
But this is dist that was generated
There was a problem hiding this comment.
Probably this thing expects us to convert types.ts to types.js as well
VsevolodX
force-pushed
the
update/SOF-7291-add-enum
branch
from
6338919
to
f1a1b0f
Compare
…-enum' into update/SOF-7291-add-enum
timurbazhirov
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.