Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/SOF-7347 update: use interface settings as class + add metadata to interface #124

Merged
merged 21 commits into from May 15, 2024

Conversation

VsevolodX
Copy link
Contributor

@VsevolodX VsevolodX commented May 10, 2024

  • chore: use interface settings as class and restructure cells
  • update: enrich names with strain
  • chore: import made from github
  • update: showcase two ways of setting the properties

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@VsevolodX VsevolodX changed the base branch from dev to feature/SOF-7352 May 10, 2024 04:46
Base automatically changed from feature/SOF-7352 to dev May 13, 2024 03:04
@@ -11,7 +11,7 @@
"<h2 style=\"color:green\">Usage</h2>\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specify whether termination selection is done


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smth like: Choose the termination selection mode: interactive with prompt or by index in the code ?

@@ -11,7 +11,7 @@
"<h2 style=\"color:green\">Usage</h2>\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #5.        distance_z=3.0,                  # distance between two planes, in Angstroms

distance between substrate and layer


Reply via ReviewNB

@VsevolodX VsevolodX merged commit 05a95b0 into dev May 15, 2024
4 checks passed
@VsevolodX VsevolodX deleted the feature/SOF-7347 branch May 15, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants