feature/SOF 7352 #123
Merged
feature/SOF 7352 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
VsevolodX
commented
May 9, 2024
VsevolodX
commented
- update: add a prompt
- update: add interactive mode for selection of t
- update: fix to work
- update: rename and return the object
- chore: import made from github
- chore: fid
- chore: import made from github
- update: sync and async functionality
- update: use new io
- update: write the only way that this works in both python and pyodide
- chore: update
- chore: explain the wheel server usage
- update: refactor to remove duplication
- update: display cells in natural size
- chore: minor adjustemtns
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
||
|
|
||
| def user_select_array_element_by_index( | ||
| array: List[Any], element_name: str = "element", prompt_head: Optional[str] = None |
utils/io.py
Outdated
| return prompt_head + prompt_body | ||
|
|
||
|
|
||
| def process_selected_index(selected_index_str: str, array: List[Any], element_name: str) -> Any: |
There was a problem hiding this comment.
What does it actually do??
utils/io.py
Outdated
| return array[selected_index] | ||
|
|
||
|
|
||
| def user_select_array_element_by_index( |
There was a problem hiding this comment.
ui_prompt_select_array_element_by_index
utils/io.py
Outdated
| ) -> Any: | ||
| prompt_text = create_prompt_text(array, element_name, prompt_head) | ||
| selected_index_str = input(prompt_text) | ||
| result = process_selected_index(selected_index_str, array, element_name) |
There was a problem hiding this comment.
index = get_integer_value_from_prompt(input(prompt_text))
result = array[index]
VsevolodX
force-pushed
the
feature/SOF-7352
branch
from
39fc280
to
3e51a12
Compare
timurbazhirov
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.