Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DB-26-4] Fix leaderId and epoch number returning empty in telemetry for read only replica and follower node that joins later #4256

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lakshdeepsingheventstore
Copy link
Contributor

@lakshdeepsingheventstore lakshdeepsingheventstore commented May 8, 2024

Fixed : LeaderId and Epoch number would sometimes be empty (Guid.empty) for a follower node or a read only replica that would join a cluster whose leader is already elected. https://eventstore.aha.io/develop/requirements/DB-26-4 . Linear Issue

@timothycoleman timothycoleman changed the title Fix leaderId and epoch number returning empty in telemetry for read only replica and follower node that joins later [DB-26-4] Fix leaderId and epoch number returning empty in telemetry for read only replica and follower node that joins later May 10, 2024
@timothycoleman timothycoleman self-requested a review May 13, 2024 13:22
Copy link
Member

@YoEight YoEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it only misses some tests.

…follower node joining the cluster later with added tests
…follower node joining the cluster later with added tests
…follower node joining the cluster later with added tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants