[DB-26-16] Log an error when node certificate is not a valid server certificate #4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayley-jean
changed the title
hayley-jean
force-pushed
the
hayley-jean/add-key-usage-error-logs
branch
from
10e6a30
to
4fd77ee
Compare
shaan1337
reviewed
May 8, 2024
...ntStore.Core/Services/Transport/Http/Authentication/NodeCertificateAuthenticationProvider.cs
Outdated
Show resolved
Hide resolved
shaan1337
reviewed
May 8, 2024
...ntStore.Core/Services/Transport/Http/Authentication/NodeCertificateAuthenticationProvider.cs
Outdated
Show resolved
Hide resolved
hayley-jean
force-pushed
the
hayley-jean/add-key-usage-error-logs
branch
from
20a7e1b
to
720ad5d
Compare
shaan1337
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: Log an error when the node certificate is not a valid server certificate
Update the documentation to include the stricter certificate requirements.
If you provide a node certificate with invalid key usages (e.g. missing a required key usage), the server will now log an error:
The error is only logged if the provided certificate matches the reserved node common name, and has IP or DNS addresses in the SAN.