Extend ESDB metrics for Persistent Subscriptions #4248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhingrak
force-pushed
the
kunaldhingra/db-694-metrics-for-persistent-subscriptions
branch
3 times, most recently
from
e43e88f
to
b8223da
Compare
dhingrak
force-pushed
the
kunaldhingra/db-694-metrics-for-persistent-subscriptions
branch
5 times, most recently
from
4796314
to
a1b23ae
Compare
dhingrak
force-pushed
the
kunaldhingra/db-694-metrics-for-persistent-subscriptions
branch
from
a1b23ae
to
bbcb76c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: Extend ESDB metrics for Persistent Subscriptions
Fixes ESDB-116-2
For persistent subscription metrics, I am bit unsure about the usage of Trackers as we are using the Observer only to update the metrics on demand.
Having some formatting issues after upgraded the Rider version to 2024.1.1. The settings are in place to whitespace handling but for some reasons replacing the curly braces at the end of file/function/class adding new formatted lines.