[DB-9-8] Implement writes, events and bytes metrics. #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure about the naming but the rest looks good to me |
thefringeninja
approved these changes
Apr 11, 2024
| @@ -85,6 +88,9 @@ public static class MetricsBootstrapper { | |||
| var queueBusyMetric = new AverageMetric(coreMeter, "eventstore-queue-busy", "seconds", label => new("queue", label)); | |||
| var byteMetric = new CounterMetric(coreMeter, "eventstore-io", unit: "bytes"); | |||
| var eventMetric = new CounterMetric(coreMeter, "eventstore-io", unit: "events"); | |||
| var writesMetric = new CounterMetric(coreMeter, "eventstore-io", unit: "writes"); | |||
| var writtenBytesMetric = new CounterMetric(coreMeter, "eventstore-io", unit: "bytes"); | |||
There was a problem hiding this comment.
is this going to work? it has the same name as two lines above it
hayley-jean
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: Implement writes, events and bytes metrics.
A better commit message would be that PR is tracking how many append stream commands, events and bytes the current leader of the cluster is dealing with.