[DB-26-5] Change event type of Persistent Subscription checkpoint to $SubscriptionCheckpoint #4213
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayley-jean
changed the title
hayley-jean
requested changes
Apr 24, 2024
src/EventStore.Core/Services/Storage/ReaderIndex/EventFilter.cs
Outdated
Show resolved
Hide resolved
lakshdeepsingheventstore
force-pushed
the
lakshdeepsingh/db-543-subscriptioncheckpoint-event-type-not-filtered
branch
from
6d0ee82
to
a3b073d
Compare
hayley-jean
approved these changes
May 24, 2024
hayley-jean
deleted the
lakshdeepsingh/db-543-subscriptioncheckpoint-event-type-not-filtered
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed : SubscriptionCheckpoint event type not filtered. https://linear.app/eventstore/issue/DB-543/subscriptioncheckpoint-event-type-not-filtered
Before this fix/change, the Persistent Subscription Checkpoint event was of type "SubscriptionCheckpoint". As a result, it was not filtered out, when reading only non-system events through a subscription to $all stream.
Following discussion has more details : https://discuss.eventstore.com/t/subscription-returning-system-events/5037