Base Readiness From VNode State [DB-284] #3935
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeyzimarev
changed the title
| @@ -244,9 +244,8 @@ IServiceProvider IStartup.ConfigureServices(IServiceCollection services) => Conf | |||
| .Services, | |||
| (s, subsystem) => subsystem.ConfigureServices(s)); | |||
|
|
|||
| public void Handle(SystemMessage.SystemReady _) => _ready = true; | |||
There was a problem hiding this comment.
SystemReady is only sent once the AuthenticationProvider is initialised (and subsystems and so on). So it would be worth listening for that still, because the AuthenticationProvider creates the admin user as part of initialization, but after becomming leader.
Monitoring the state as this PR does is still a nice improvement, because it allows the readiness endpoint to start returning false later if the node transitions to e.g. Unknown state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes are not ready to handle outside traffic unless they are in the leader, follower, or readonly replica states.