workaround for unusual region settings

[topic2k]

#369

[AppVeyorBot]

WIP-2019.01.29-20.05.23 completed (commit 6a2e4dc05f)
Artifacts:
Build.log
CHANGELOG.md
CHANGELOG_THIS_RELEASE.bb
CHANGELOG_THIS_RELEASE.md
EventGhost_WIP-2019.01.29-20.05.23_Setup.exe

[kdschlosser]

one thing on this. I am tired of locale issues. we need to come up with a concrete mechanism to deal with the locale before we release.

all of the locale code needs to be in a single location instead of piece here and piece there.
I do believe the language classes i did up does allow for en_DE. and odd combinations like that. I can remove the translation portion of that code. and we can add in the bits needed to make everything run properly.
what do you think about that??.. it ends up being a really nice piece of code to handle the languages. specifically because a language will not be available if the OS does not support it. I use the term language to mean language locale combination.

Now I can manually grab each of the various numeric components using the Windows API. and create our own custom locale handler that will not care what the language is or the locale for that matter. it will grab the needed values from Windows and assign them where they need to be. It would not be to difficult to do that. This would also eliminate any possibility of an issue in the future. wee couple that with the language classes and I think it might be a winning combination that is not going to be prone to any problems.

specifically because we are then not dependent on what some other module grabs from Windows. Which we are finding that these other modules are not gathering and compiling the information properly.

It's not our code that has the issues. and instead of us band-aiding the problem. we should grab the bull by the horns and do it right.

[kdschlosser]

as it turns out this problem is not a problem in python. it is a problem with Windows

build 1809 specifically. the most recent update. Microsoft sticks it to us once again.

http://www.eventghost.net/forum/viewtopic.php?f=2&t=10288&p=52829#p52829

[kdschlosser]

I think that I may have located the issue.

here is the code from the locale module for setting the locale.
watch the data path specifically the locale argument

def setlocale(category, locale=None):
    if locale and not isinstance(locale, (_str, _unicode)):
        # convert to string
        locale = normalize(_build_localename(locale))
    return _setlocale(category, locale)

we are passing "" to the local argument.
so it bypasses being normalized and gets passed as "" to the _locale extension module

ok so here is the _setlocale function in the _locale extension module.

static PyObject*
PyLocale_setlocale(PyObject* self, PyObject* args)
{
    int category;
    char *locale = NULL, *result;
    PyObject *result_object;

    if (!PyArg_ParseTuple(args, "i|z:setlocale", &category, &locale))
        return NULL;

#if defined(MS_WINDOWS)
    if (category < LC_MIN || category > LC_MAX)
    {
        PyErr_SetString(Error, "invalid locale category");
        return NULL;
    }
#endif

    if (locale) {
        /* set locale */
        result = setlocale(category, locale);
        if (!result) {
            /* operation failed, no setting was changed */
            PyErr_SetString(Error, "unsupported locale setting");
            return NULL;
        }
        result_object = PyString_FromString(result);
        if (!result_object)
            return NULL;
        /* record changes to LC_CTYPE */
        if (category == LC_CTYPE || category == LC_ALL)
            fixup_ulcase();
        /* things that got wrong up to here are ignored */
        PyErr_Clear();
    } else {
        /* get locale */
        result = setlocale(category, NULL);
        if (!result) {
            PyErr_SetString(Error, "locale query failed");
            return NULL;
        }
        result_object = PyString_FromString(result);
    }
    return result_object;
}

in the report of the problem the error
locale.Error: unsupported locale setting
is what is given. there is only a single place in the code above that has
this error.

    if (locale) {
        /* set locale */
        result = setlocale(category, locale);
        if (!result) {
            /* operation failed, no setting was changed */
            PyErr_SetString(Error, "unsupported locale setting");
            return NULL;
        }

now evn tho we are passing "" to the locale parameter for some reason it is
being interpreted as a True statement. It should not be processed here.
I believe microsoft has fixed an issue with the setting of the locale in build
1806 in the past passing "" to the set locale function for windows was how it
had to be done. and now it is not I am gathering.

I think that this is thee code block we now need to have run.

    } else {
        /* get locale */
        result = setlocale(category, NULL);
        if (!result) {
            PyErr_SetString(Error, "locale query failed");
            return NULL;
        }
        result_object = PyString_FromString(result);
    }

so maybe changing locale.setlocale(locale.LC_ALL, '') to locale.setlocale(locale.LC_ALL, None) might fix the problem.

we can do a simple try except to catch the problem

import locale


try:
    locale.setlocale(locale.LC_ALL, '')
except locale.Error:
    locale.setlocale(locale.LC_ALL, None)
    

thee only way to know is a user is going to have to bee running build 1806 of Windows