[EventGhost] - Obsolete - Removes ctypeslib as a dependency. #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From what I can find ctypeslib is only used to create WinApi.Dynamic It is no longer being maintained. In order for it to run it requires. GCC-XML which is also no longer being maintained. It has been succeeded by Cast-XML which is not compatible with ctypes lib. you can download an old version of GCC-XML the problem is that it only works with MSVC 6, 7 or 7.1. There is a fork on Pypi that uses Clang, but it is not complete and does not function for what EG would use it for. what ctypeslib does is it creates python versions of C/C++ code. What EG used it for was converting some of the Windows API. I already have 500K lines of code of the Windows API converted from Windows Vista to the latest build of Windows 10. So it is pretty much obsolete and no longer needed.
|
Code Climate has analyzed commit fbb23c5 and detected 0 issues on this pull request. View more on Code Climate. |
|
As the build don't fail and a short test of the build exe didn't show any errors, i think we can merge it. But to not accidently introduce any new bugs i would merge it after the release of 0.5. |
|
hence the reason i did not add a Milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes ctypeslib as a dependency.
From what I can find ctypeslib is only used to create WinApi.Dynamic
It is no longer being maintained. In order for it to run it requires.
GCC-XML which is also no longer being maintained. It has been succeeded
by Cast-XML which is not compatible with ctypes lib. you can download
an old version of GCC-XML the problem is that it only works with
MSVC 6, 7 or 7.1. There is a fork on Pypi that uses Clang, but it is
not complete and does not function for what EG would use it for.
what ctypeslib does is it creates python versions of C/C++ code.
What EG used it for was converting some of the Windows API.
I already have 500K lines of code of the Windows API converted from
Windows Vista to the latest build of Windows 10. So it is pretty much
obsolete and no longer needed.