[Builder] - BugFix - CheckDependencies.py pip._veendor.requests traceback

[kdschlosser]

There appears to be a glitch in version 18.1 of pip. I am not sure how
far back in the versions this problem goes. I do know that if you use
version 9.0.3 of pip when building EG everything is fine.

The problem produces a traceback when importing CheckDependencies

    from pip._vendor import requests
  File "C:\Stackless27\lib\site-packages\pip\_vendor\requests\__init__.py", line 94, in <module>
    from pip._internal.utils.compat import WINDOWS
  File "C:\Stackless27\lib\site-packages\pip\_internal\__init__.py", line 40, in <module>
    from pip._internal.cli.autocompletion import autocomplete
  File "C:\Stackless27\lib\site-packages\pip\_internal\cli\autocompletion.py", line 8, in <module>
    from pip._internal.cli.main_parser import create_main_parser
  File "C:\Stackless27\lib\site-packages\pip\_internal\cli\main_parser.py", line 12, in <module>
    from pip._internal.commands import (
  File "C:\Stackless27\lib\site-packages\pip\_internal\commands\__init__.py", line 6, in <module>
    from pip._internal.commands.completion import CompletionCommand
  File "C:\Stackless27\lib\site-packages\pip\_internal\commands\completion.py", line 6, in <module>
    from pip._internal.cli.base_command import Command
  File "C:\Stackless27\lib\site-packages\pip\_internal\cli\base_command.py", line 18, in <module>
    from pip._internal.download import PipSession
  File "C:\Stackless27\lib\site-packages\pip\_internal\download.py", line 15, in <module>
    from pip._vendor import requests, six, urllib3
ImportError: cannot import name requests

They seem to have a broken dynamic import system. So I removed importing
requests from pip._vendor and replaced it with urllib2.urlopen

[AppVeyorBot]

WIP-2019.01.18-11.25.39 completed (commit e03400cbac)
Artifacts:
Build.log
CHANGELOG.md
CHANGELOG_THIS_RELEASE.bb
CHANGELOG_THIS_RELEASE.md
EventGhost_WIP-2019.01.18-11.25.39_Setup.exe

[AppVeyorBot]

908-master completed (commit e653b28efb)
Artifacts:
Build.log

[codeclimate]

Code Climate has analyzed commit 41ebaf2 and detected 0 issues on this pull request.

View more on Code Climate.

[topic2k]

I don't know why, but appveyor didn't recognized the changes in .appveyor.yml and thus used the cached environment. That means pip 9.01 were used for the build (take a look at the console output of appveyor).

In pip 18.1 the used function get_installed_distributions() has been moved to another sub-modul. You now need to import pip._internal and change the call in line 162 to pip._internal.utils.misc.get_installed_distributions

[kdschlosser]

no it did invalidate the cache

Invalidated as some dependencies (.appveyor.yml) have changed

and that is also why it errored if you scroll down to the bottom. Now the question is why did it say it was successful. when it was not.

I do have to fix the get_installed_distributions. it is moved in newer versions of PIP.