Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventGhost] - MAJOR ENHANCEMENT - Adds x64 builds #321

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kdschlosser
Copy link
Member

This is a big overhaul. I had to create a mechanism to properly detect Visual C and also detect the installed run time libraries. as well as detect the .NET version and the Windows SDK. It sets all the proper environment variables. It also updates the solution files of the extension DLL files so they will build properly using MSBuild.

I rewrote the AppVeyor script so it works with build matrix so it now does 2 build jobs one for x86 and one for x64 I moved all of the Powershell code into ps1 files. this is much easier to change if you install the PowerShell plugin for PyCharm. I had to add to the downloads there is no variant of py2exe available for Python 2.7 x64 on pypi So it s downloaded and installed form source forge. I rewrote the download process it now uses jobs so all the downloads run at the same time. and if Stackless finishes it goes on to install it while the other downloads are still running.

I added the build of the extensions to the call to distutils.core.setup. this is a step in the right direction for a proper build. I am going to convert the solution files to be directly built by distutils in the future. and not have MSBuild run a solution file.

I rewrote the portion of the build that does the module detection. I still have not figured out what the purpose to Build Imports is. the actual file it makes never gets imported anywhere. I do feel that we should remove the use of the global module index. it serves no purpose after the update I made for detecting packages. Because of this update it has caused EG to get chunky. so the setup file is no longer 18 meg. it is more along the lines of 24ish i think, This is because more of the standard modules are now included. the detection process i use actually overrides the import then imports one of the required modules like pill. it then logs all of the imports that take place for that module. and based off those imports it iterates over the directory the imported file is located and then proceeds to import those modules. this creates a cascading effect. which then gives us every single module that could possibly be used. we add that with a simple iteration of the python DLL and LIB folder (not site-packages) and we add all of the standard modules that have not been added already.

This is a big overhaul. I had to create a mechanism to properly detect Visual C and also detect the installed run time libraries. as well as detect the .NET version and the Windows SDK. It sets all the proper environment variables. It also updates the solution files of the extension dll files so they will build properly using msbuild.

I rewrote the appveyor script so it works with build matrix so it now does 2 build jobs one for x86 and one for x64 I moved all of the Powershell code into ps1 files. this is much easier to change if you install the PowerShell plugin for PyCharm. I had to add to the downloads there is no variant of py2exe available for Python 2.7 x64 on pypi So it s downloaded and installed form source forge. I rewrote the download process it now uses jobs so all the downloads run at the same time. and if Stackless finishes it goes on to install it while the other downloads are still running.

I added the build of the extensions to the call to distutils.core.setup. this is a step in the right direction for a proper build. I am going to convert the solution files to be directly built by distutils in the future. and not have msbuild run a solution file. 

I rewrote the portion of the build that does the module detection. I still have not figured out what the purpose to Build Imports is. the actual file it makes never gets imported anywhere. I do feel that we should remove the use of the global module index. it serves no purpose after the update I made for detecting packages. Because of this update it has caused EG to get chunky. so the setup file is no longer 18 meg. it is more along the lines of 24ish i think, This is because more of the standard modules are now included. the detection process i use actually overrides the __import__ then imports one of the required modules like pill. it then logs all of the imports that take place for that module. and based off those imports it iterates over the directory the imported file is located and then proceeds to import those modules. this creates a cascading effect. which then gives us every single module that could possibly be used. we add that with a simple iteration of the python DLL and LIB folder (not site-packages) and we add all of the standard modules that have not been added already.
@topic2k topic2k added the WIP label Oct 20, 2018
@kdschlosser
Copy link
Member Author

I managed to get all of the extensions to build properly using only distutils. no need to call msbuild at all and no need to have the program modify solution files. I will be updating this code soon

@topic2k topic2k modified the milestones: v0.5, v0.6 Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants