[EventGhost] - Enhancement - Several, Adds EventGhostEnduringEvent class and icon #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is no means of knowing what kind of event has been triggered. This modification fixes that problem. A different icon is now used to identify an enduring event from a standard one. This will make it far easier for the user to implement looping code to perform actions in succession. I was pretty crafty in how i display the icon. because i not only wanted to have the icon changed in the log but also in the tree as well. once an event has been triggered and set as an enduring event it will change the icon in the tree. when an event is added to the tree it will check and see if that event has been flagged as an enduring event. if so it will change the new events icon accordingly. an XML attribute of EventType is added to the save data to identify the icon to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no means of knowing what kind of event has been triggered. This modification fixes that problem. A different icon is now used to identify an enduring event from a standard one. This will make it far easier for the user to implement looping code to perform actions in succession.
I was pretty crafty in how i display the icon. because i not only wanted to have the icon changed in the log but also in the tree as well. once an event has been triggered and set as an enduring event it will change the icon in the tree. when an event is added to the tree it will check and see if that event has been flagged as an enduring event. if so it will change the new events icon accordingly. an XML attribute of EventType is added to the save data to identify the icon to use.
The reason for the bugfix label is because this was technically something that should have been done and is in the gray area of being a bug