[EventGhost] - Enhancement - ConfigPanel.py, Equalizes the widths of the StaticText controls when using AddLine #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the AddLine method of eg.ConfigPanel this causes the labels and controls to be rendered in a not so pleasing manner. I have added the equalizing of even numbered columns if the control is a wx.StaticText instance and if there are more column items in that specific row. it will add these instances into matching groupes based on column number. and each grouping of controls then get passed to EqualizeWidths. This produces a much nicer looking dialog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the AddLine method of eg.ConfigPanel this causes the labels and controls to be rendered in a not so pleasing manner. I have added the equalizing of even numbered columns if the control is a wx.StaticText instance and if there are more column items in that specific row. it will add these instances into matching groups based on column number. and each grouping of controls then get passed to EqualizeWidths.
This produces a much nicer looking dialog. without messing up any description lines or help lines.
I am unsure if there are any use cases where this may cause an issue. I have not been able to locate one So be sure to test it if you know of a plugin that uses AddGrid or AddLine in an odd manner.
I could target this to be specific to AddLine. I would have to create the Controls if any text is present in the AddLine method instead of where they are currently created in the AddGrid method.