Changes for project-setting service to use schema, knex & feathers 5 #8746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzlamateen
requested changes
Sep 14, 2023
barankyle
approved these changes
Sep 14, 2023
barankyle
approved these changes
Sep 19, 2023
hanzlamateen
approved these changes
Sep 20, 2023
barankyle
pushed a commit
that referenced
this pull request
Oct 13, 2023
…8746) * Migrated project-setting service * Updated imports * Updated project find method * Removed project-setting service * Updated imports * Fixed project resolvers * Ensuring cloned params * Updated condition for allowed * Ensuring project-setting is object * Added user in project permission find params * Moved resolver converter * Updated project find return type * Updated fetchProjects * Added useGet * Added paginate false * Updated useGet * Removed paginate false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Project-setting service has been removed. Now project service methods are used to get and patch settings. Issue #8760 has also been fixed in this PR.
References
#7645, closes #8742, #8760
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.