Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for project manifest.json #10144

Merged
merged 24 commits into from May 14, 2024
Merged

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented May 10, 2024

Summary

  • Adds manifest.json spec to supersede package.json and xrengine.config.ts as required project files
  • Makes asset service generic instead of specific for scene GLTFs
  • Adds helpful resolvers to asset and location services
  • Improve git API unit tests
  • Upload all resources to storage provider as part of seeding projects
  • Studio file upload helper functions no longer hardcodes directory for uploaded assets
  • A manifest.json automatically generates in projects that do not have one
  • Scene CRUD operations update manifest.json scenes field

Subtasks Checklist

Breaking Changes

References

closes #insert number here

QA Steps

@HexaField HexaField changed the title IR-1926-project-manifest-json Add support for project manifest.json May 10, 2024
@HexaField HexaField marked this pull request as ready for review May 13, 2024 02:08
@HexaField HexaField marked this pull request as draft May 13, 2024 02:59
@HexaField HexaField marked this pull request as ready for review May 13, 2024 05:42
Copy link
Member

@hanzlamateen hanzlamateen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I added a new scene and it was not reflected in manifest.json.
  2. I renamed apartment scene and it was not reflected in manifest.json

@DanielBelmes
Copy link
Contributor

You can rename a scene into an already existing scene and it fails in SQL but pushes to manifest.

So default when no scenes are detected is no scenes key (edited)
but if you delete all scenes it's scenes: []
could lead to logic issues if the condition only checks for length

@HexaField
Copy link
Member Author

You can rename a scene into an already existing scene and it fails in SQL but pushes to manifest.

So default when no scenes are detected is no scenes key (edited) but if you delete all scenes it's scenes: [] could lead to logic issues if the condition only checks for length

Restructuring into after hooks will take a bit of work, and I can just solve that one problem and we can use validators to ensure the data is compliant before it hits the mutation hooks. We can restructure the effects of hooks another time, but it is a good point to raise.

Copy link
Member

@hanzlamateen hanzlamateen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Assuming Daniel's comments will be handled in a separate PR

@HexaField HexaField requested a review from barankyle May 14, 2024 21:24
@HexaField HexaField requested a review from MoizAdnan May 14, 2024 21:29
@HexaField HexaField enabled auto-merge May 14, 2024 21:29
@HexaField HexaField disabled auto-merge May 14, 2024 21:29
@HexaField HexaField merged commit a381816 into dev May 14, 2024
13 checks passed
@HexaField HexaField deleted the IR-1926-project-manifest-json branch May 14, 2024 21:49
@HexaField HexaField mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants