Auto-AFK issue: AFK timer not reset on disconnect

[takatalvi]

Today I updated to the latest version of EssX and I noticed that cancel-afk-on-move and cancel-afk-on-interact now work separately, which is great and I already made use of it. However, as my players noticed, and based on what they reported to me, I think there could be two additional settings (working separately from the two above) - cancel-afk-on-chat (applies to global chat and to /msg or /r), and cancel-afk-on disconnect (because now players are able to join in afk status, which in some cases means quick auto-kick, when their counter for auto-afk-kick is filled shortly after joining.

[mdcfe]

Players' AFK timers shouldn't be stored when they log off - that's an oversight on our part.

I'm not entirely sure whether having a separate cancel-afk-on-chat is necessarily particularly useful - if we added it, we'd need to then change cancel-afk-on-interact's behaviour to not overlap with that option, and that would break existing behaviour in Essentials that has existed for years.

[takatalvi]

Yes, that's what I was thinking. The counter should be reset on disconnect in any case, so I guess that is a bug. Regarding chat, I wanted to allow chat messages to reset the counter, but not right-click interactions. This could allow me to prevent people from afk-fishing, while not kicking people who just stand in the same spot and chat.

[Dolphin2Point1]

I'll try making a pr for this.

[takatalvi]

Thanks, any update is appreciated :)

[Dolphin2Point1]

I'm changing much more files than they did in the original pr.

[NorbiPeti]

When can we expect a fix to be released for kicking on login? Our players get kicked almost every time they join, so we had to disable the auto kick.

freeze-afk-players: false
disable-item-pickup-while-afk: true
cancel-afk-on-interact: false
cancel-afk-on-move: true

Using EssentialsX 2.15.0.16