Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(block-section): add
icon
property (deprecatesstatus
) #9194feat(block-section): add
icon
property (deprecatesstatus
) #9194Changes from 18 commits
34c89e7
cfd2feb
a59e66b
c3b1822
f7dedd1
c56c0c2
bbc218a
d593ed7
be02634
8576a7c
b058e53
c8d42e1
7ee0cc3
3042e20
8e1b7d3
bc0fa4b
d2b9ad8
6ea00d4
a0200d9
4aacdd9
4eb19a5
cebb0a9
cbdd375
99432fe
833133a
f58845f
fea2abd
c9cf981
c8d3644
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to use the
getIconScale
util?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
block/block-section
don't havescale
currently. It'll be reviewed in #7082. As is, we think of the components that don't have scale asmedium
and usesmall
icons for them.