Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Identify Items That Use Insecure URLs sample notebook #1821

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tarunkukreja003
Copy link
Collaborator

@tarunkukreja003 tarunkukreja003 commented May 9, 2024

resolves #9781

Note:
this notebook scans the whole organization and identifies items that use insecure URLs,
some of the output had to be edited because some items are not working - for example - gis.content.get('88282a83d8b445b89a5225039c65616a')
the user who will consume the sample notebook can log in to their AGOL and Enterprise organization and if all the items in their organization are good, then they'll not face any errors running this sample notebook

Testing instructions:

Step 1: In the get_items_to_check() method definition please put max_items=2
Step 2: In the main() method definition please replace the following statement:
for item in get_items_to_check(): with

item1 = gis.content.get('bc6a732940e84e67a07b4dc299e0f5cf')
item2 = gis.content.get('8ace59c5a8be401bbddaccfae0a39305')
item_array = [item1, item2]
for item in item_array:

Please don't run the Post Processing section since that output has been created and edited and will only work if all items in the organization are good and running fine

Please add comments if you face issues

@tarunkukreja003 tarunkukreja003 self-assigned this May 9, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@ManushiM ManushiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just have one question - where in the notebook are we adding the note/disclaimer that the end user needs to run this off their own workspace?

@tarunkukreja003
Copy link
Collaborator Author

tarunkukreja003 commented May 9, 2024

Looks good to me. I just have one question - where in the notebook are we adding the note/disclaimer that the end user needs to run this off their own workspace?

thanks @ManushiM for the review, we don't need to specify that a user needs to setup their own workspace path since I have added a ./ before arcgis/home so it will create a arcgis/home directory at the current path, so it will not give Directory not found error

@ManushiM
Copy link
Collaborator

Looks good to me. I just have one question - where in the notebook are we adding the note/disclaimer that the end user needs to run this off their own workspace?

thanks @ManushiM for the review, we don't need to specify that a user needs to setup their own workspace path since I have added a ./ before arcgis/home so it will create a arcgis/home directory at the current path, so it will not give Directory not found error

That's fair, cool this works then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants