Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to swift 4.2 #496

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Updating to swift 4.2 #496

wants to merge 5 commits into from

Conversation

Khalian
Copy link
Collaborator

@Khalian Khalian commented Nov 8, 2018

Checklist

  • New Extension
  • New Test
  • Changed more than one extension, but all changes are related
  • Trivial change (doesn't require changelog)

@EZSwiftExtensionsBot
Copy link

EZSwiftExtensionsBot commented Nov 8, 2018

1 Error
🚫 Please, modify only one extension per pull request.
8 Warnings
⚠️ Sources/TimePassed.swift#L24: Operator Function Whitespace Violation: Operators should be surrounded by a single whitespace when defining them. (operator_whitespace)
#import "Headers/EZSwiftExtensions-Swift.h"
⚠️ /Users/travis/Library/Developer/Xcode/DerivedData/EZSwiftExtensions-cknupuhyerhvhtfuqvigkfkoxukr/Build/Products/Debug-iphonesimulator/EZSwiftExtensions.framework/Headers/EZSwiftExtensions-Swift.h#L244: ‘UIWebView’ is deprecated: first deprecated in iOS 12.0 - No longer supported; please adopt WKWebView.
@interface BlockWebView : UIWebView <UIWebViewDelegate>
⚠️ /Users/travis/Library/Developer/Xcode/DerivedData/EZSwiftExtensions-cknupuhyerhvhtfuqvigkfkoxukr/Build/Products/Debug-iphonesimulator/EZSwiftExtensions.framework/Headers/EZSwiftExtensions-Swift.h#L247: ‘UIWebView’ is deprecated: first deprecated in iOS 12.0 - No longer supported; please adopt WKWebView.
```

  • (void)webViewDidStartLoad:(UIWebView * _Nonnull)webView;
    ```
  • <
⚠️ /Users/travis/Library/Developer/Xcode/DerivedData/EZSwiftExtensions-cknupuhyerhvhtfuqvigkfkoxukr/Build/Products/Debug-iphonesimulator/EZSwiftExtensions.framework/Headers/EZSwiftExtensions-Swift.h#L248: ‘UIWebView’ is deprecated: first deprecated in iOS 12.0 - No longer supported; please adopt WKWebView.
```

  • (void)webViewDidFinishLoad:(UIWebView * _Nonnull)webView;
    ```
  • <
⚠️ /Users/travis/Library/Developer/Xcode/DerivedData/EZSwiftExtensions-cknupuhyerhvhtfuqvigkfkoxukr/Build/Products/Debug-iphonesimulator/EZSwiftExtensions.framework/Headers/EZSwiftExtensions-Swift.h#L249: ‘UIWebView’ is deprecated: first deprecated in iOS 12.0 - No longer supported; please adopt WKWebView.
```

  • (void)webView:(UIWebView * _Nonnull)webView didFailLoadWithError:(NSError * _Nonnull)error;
    ```
  • <
⚠️ /Users/travis/Library/Developer/Xcode/DerivedData/EZSwiftExtensions-cknupuhyerhvhtfuqvigkfkoxukr/Build/Products/Debug-iphonesimulator/EZSwiftExtensions.framework/Headers/EZSwiftExtensions-Swift.h#L250: ‘UIWebView’ is deprecated: first deprecated in iOS 12.0 - No longer supported; please adopt WKWebView.
```

  • (BOOL)webView:(UIWebView * _Nonnull)webView shouldStartLoadWithRequest:(NSURLRequest * _Nonnull)request navigationType:(enum UIWebViewNavigationType)navigationType SWIFT_WARN_UNUSED_RESULT;
    ```
  • <
⚠️ The use of Swift 3 @objc inference in Swift 4 mode is deprecated. Please address deprecated @objc inference warnings, test your code with “Use of deprecated Swift 3 @objc inference” logging enabled, and then disable inference by changing the “Swift 3 @objc Inference” build setting to “Default” for the “EZSwiftExtensions” target. (in target ‘EZSwiftExtensions’)
⚠️ The use of Swift 3 @objc inference in Swift 4 mode is deprecated. Please address deprecated @objc inference warnings, test your code with “Use of deprecated Swift 3 @objc inference” logging enabled, and then disable inference by changing the “Swift 3 @objc Inference” build setting to “Default” for the “EZSwiftExtensionsTests” target. (in target ‘EZSwiftExtensionsTests’)
1 Message
📖 Executed 125 tests, with 0 failures (0 unexpected) in 4.008 (4.099) seconds

Generated by 🚫 Danger

@Khalian Khalian force-pushed the swift4.2official branch 2 times, most recently from 71875ed to 17e3821 Compare November 8, 2018 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants