Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Swift4.0.2 characters warnings #465

Open
wants to merge 1 commit into
base: swift4
Choose a base branch
from
Open

fix Swift4.0.2 characters warnings #465

wants to merge 1 commit into from

Conversation

upoahz
Copy link

@upoahz upoahz commented Nov 2, 2017

Checklist

  • New Extension
  • New Test
  • Changed more than one extension, but all changes are related
  • Trivial change (doesn't require changelog)

@EZSwiftExtensionsBot
Copy link

34 Errors
🚫 Making non-trivial change requires changelog entry! Please, set trivial change or add entry to changelog.
🚫 Sources/ArrayExtensions.swift#L76: value of type ‘Array<Element>’ has no member ‘swapAt’
if i != i+j { self.swapAt(i, i+j) }
🚫 Sources/UITextFieldExtensions.swift#L68: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
return self.text!.count == count
🚫 Sources/UITextFieldExtensions.swift#L70: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
return self.text!.count > count
🚫 Sources/UITextFieldExtensions.swift#L72: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
return self.text!.count >= count
🚫 Sources/UITextFieldExtensions.swift#L74: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
return self.text!.count < count
🚫 Sources/UITextFieldExtensions.swift#L76: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
return self.text!.count <= count
🚫 Sources/NSAttributedStringExtensions.swift#L31: use of unresolved identifier ‘NSAttributedStringKey’
copy.addAttributes([NSAttributedStringKey.underlineStyle: NSUnderlineStyle.styleSingle.rawValue], range: range)
🚫 Sources/NSAttributedStringExtensions.swift#L65: use of unresolved identifier ‘NSAttributedStringKey’
copy.addAttributes([NSAttributedStringKey.foregroundColor: color], range: range)
🚫 Sources/StringExtensions.swift#L57: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
return self.count
🚫 Sources/StringExtensions.swift#L305: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
detector.enumerateMatches(in: text, options: [], range: NSRange(location: 0, length: text.count), using: {(result: NSTextCheckingResult?, _, _) -> Void in
🚫 Sources/StringExtensions.swift#L67: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
guard count > 0 else { return }
🚫 Sources/StringExtensions.swift#L73: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
guard count > 0 else { return self }
🚫 Sources/StringExtensions.swift#L115: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
guard count > 0 && (0..<length).contains(from) else { return }
🚫 Sources/StringExtensions.swift#L123: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
guard count > 0 && (0..<length).contains(from) else { return self }
🚫 Sources/StringExtensions.swift#L132: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
guard count > 0 else { return }
🚫 Sources/StringExtensions.swift#L138: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
guard count > 0 else { return self }
🚫 Sources/StringExtensions.swift#L179: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
guard count > 0 && (0..<length).contains(from) else { return }
🚫 Sources/StringExtensions.swift#L187: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
guard count > 0 && (0..<length).contains(from) else { return self }
🚫 Sources/StringExtensions.swift#L379: use of unresolved identifier ‘NSAttributedStringKey’
let underlineString = NSAttributedString(string: self, attributes: [NSAttributedStringKey.underlineStyle: NSUnderlineStyle.styleSingle.rawValue])
🚫 Sources/StringExtensions.swift#L413: use of unresolved identifier ‘NSAttributedStringKey’
let colorString = NSMutableAttributedString(string: self, attributes: [NSAttributedStringKey.foregroundColor: color])
🚫 Sources/StringExtensions.swift#L432: use of unresolved identifier ‘NSAttributedStringKey’
attrText.addAttribute(NSAttributedStringKey.foregroundColor, value: color, range: range)
🚫 Sources/ArrayExtensions.swift#L76: value of type ‘Array<Element>’ has no member ‘swapAt’
if i != i+j { self.swapAt(i, i+j) }
🚫 Sources/StringExtensions.swift#L57: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
return self.count
🚫 Sources/StringExtensions.swift#L305: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
detector.enumerateMatches(in: text, options: [], range: NSRange(location: 0, length: text.count), using: {(result: NSTextCheckingResult?, _, _) -> Void in
🚫 Sources/StringExtensions.swift#L67: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
guard count > 0 else { return }
🚫 Sources/StringExtensions.swift#L73: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
guard count > 0 else { return self }
🚫 Sources/StringExtensions.swift#L115: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
guard count > 0 && (0..<length).contains(from) else { return }
🚫 Sources/StringExtensions.swift#L123: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
guard count > 0 && (0..<length).contains(from) else { return self }
🚫 Sources/StringExtensions.swift#L132: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
guard count > 0 else { return }
🚫 Sources/StringExtensions.swift#L138: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
guard count > 0 else { return self }
🚫 Sources/StringExtensions.swift#L179: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
guard count > 0 && (0..<length).contains(from) else { return }
🚫 Sources/StringExtensions.swift#L187: ‘count’ is unavailable: there is no universally good answer, see the documentation comment for discussion
guard count > 0 && (0..<length).contains(from) else { return self }
🚫 Sources/StringExtensions.swift#L379: use of unresolved identifier ‘NSAttributedStringKey’
let underlineString = NSAttributedString(string: self, attributes: [NSAttributedStringKey.underlineStyle: NSUnderlineStyle.styleSingle.rawValue])
8 Warnings
⚠️ Sources/FloatingPointExtensions.swift#L17: result of operator ‘*’ is unused
for _ in 0..<places { divisor * 10 }
⚠️ Sources/FloatingPointExtensions.swift#L16: variable ‘divisor’ was never mutated; consider changing to ‘let’ constant
var divisor: Self = 1
⚠️ Sources/FloatingPointExtensions.swift#L30: result of operator ‘*’ is unused
for _ in 0..<places { divisor * 10 }
⚠️ Sources/FloatingPointExtensions.swift#L29: variable ‘divisor’ was never mutated; consider changing to ‘let’ constant
var divisor: Self = 1
⚠️ Sources/FloatingPointExtensions.swift#L17: result of operator ‘*’ is unused
for _ in 0..<places { divisor * 10 }
⚠️ Sources/FloatingPointExtensions.swift#L16: variable ‘divisor’ was never mutated; consider changing to ‘let’ constant
var divisor: Self = 1
⚠️ Sources/FloatingPointExtensions.swift#L30: result of operator ‘*’ is unused
for _ in 0..<places { divisor * 10 }
⚠️ Sources/FloatingPointExtensions.swift#L29: variable ‘divisor’ was never mutated; consider changing to ‘let’ constant
var divisor: Self = 1

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants