Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<Description> : Adding NSAttributed string data extension. #379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

<Description> : Adding NSAttributed string data extension. #379

wants to merge 1 commit into from

Conversation

Khalian
Copy link
Collaborator

@Khalian Khalian commented Feb 13, 2017

: feature/test

Checklist

  • New Extension
  • New Test
  • Changed more than one extension, but all changes are related
  • Trivial change (doesn't require changelog)

lfarah
lfarah reviewed Feb 13, 2017
View reviewed changes
Sources/DataExtensions.swift Outdated
public var attributedString: NSAttributedString? {
do {
return try NSAttributedString(data: self, options:[NSDocumentTypeDocumentAttribute:NSHTMLTextDocumentType, NSCharacterEncodingDocumentAttribute: String.Encoding.utf8.rawValue], documentAttributes: nil)
} catch let error as NSError {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Khalian Do we need to use NSError or we can use Swift's Error?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good callout. I fixed that.

@EZSwiftExtensionsBot
Copy link

EZSwiftExtensionsBot commented Feb 13, 2017 •
edited

3 Errors
🚫 EZSwiftExtensionsTest.UIColorTests: testBlueComponent, XCTAssertEqual failed: (“4607182418800017409”) is not equal to (“255”) -
EZSwiftExtensionsTests/UIColorTests.swift#L62
🚫 EZSwiftExtensionsTest.UIColorTests: testGreenComponent, XCTAssertEqual failed: (“4607182418800017409”) is not equal to (“255”) -
EZSwiftExtensionsTests/UIColorTests.swift#L57
🚫 EZSwiftExtensionsTest.UIColorTests: testRedComponent, XCTAssertEqual failed: (“4607182418800017409”) is not equal to (“255”) -
EZSwiftExtensionsTests/UIColorTests.swift#L52
2 Messages
📖 Executed 195 tests, with 3 failures (0 unexpected) in 6.887 (7.155) seconds
📖 Executed 178 tests, with 0 failures (0 unexpected) in 4.960 (5.161) seconds

Generated by 🚫 Danger

@Khalian
Copy link
Collaborator Author

Khalian commented Feb 13, 2017

UIColor Tests are blowing up for some reason.

@SD10 SD10 mentioned this pull request Jan 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfarah lfarah lfarah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Khalian @EZSwiftExtensionsBot @lfarah