Keep same extension when created tmp config file #885
+47
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The users script may not work properly if the config file does not have the expected extension. We should keep the same one instead of turning it into .conf.
bouthilx
added
bug
lebrice
approved these changes
May 17, 2022
|
|
||
| assert original_ext == tmp_ext | ||
|
|
||
| shutil.rmtree(trial.working_dir) |
There was a problem hiding this comment.
Why is it necessary to do this? Shouldn't the working directory in the config always be based on the temp_path fixture?
There was a problem hiding this comment.
It's because of this line: https://github.com/Epistimio/orion/pull/885/files#diff-5fe3b7fe336f5a8a566e677336db8fc5f708b6da4e5662fef48c7bfc95fc1c42R34. We could perhaps convert it to temp_path.
| @@ -197,9 +194,16 @@ def get_execution_environment(self, trial, results_file="results.log"): | |||
|
|
|||
| return env | |||
|
|
|||
| def _consume(self, trial, workdirname): | |||
| def _prepare_config(self, trial, workdirname): | |||
There was a problem hiding this comment.
Nit: I know your stance is to add type hints to new modules, but I think new methods might also be a good opportunity to add type hints.
|
Must adapt doc after merging #957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The users script may not work properly if the config file does not have the expected extension. We should keep the same one instead of turning it into .conf.
@hnekoeiq