Check for lost processes and threads #791
Open
+50
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many tests leave running processes or threads in the backgrounds. There are both cause of tests randomly hanging and side-effects during other tests latter on. We should verify at end of each tests that no processes or threads are left running.
bouthilx
added a commit
to bouthilx/orion
that referenced
this pull request
Feb 11, 2022
lebrice
pushed a commit
to lebrice/orion
that referenced
this pull request
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many tests leave running processes or threads in the backgrounds. There
are both cause of tests randomly hanging and side-effects during other
tests latter on. We should verify at end of each tests that no processes
or threads are left running.
Note
Commit for github-actions and tox.ini should be removed before merge. This is just to focus the CI on the faulty tests while I am still debugging.
Other note
The test
test_storage.py::test_acquire_algorithm_lock_timeoutshould be adjusted when all lost processes and threads are adressed.