Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order Space by insertion order #1104

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

NeilGirdhar
Copy link
Contributor

Now that dictionaries are ordered by insertion order, sorting lexicographically is not necessary to ensure consistency.

Fixes #1103

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

NeilGirdhar and others added 4 commits July 6, 2023 15:09
Now that dictionaries are ordered by insertion order, sorting
lexicographically is not necessary to ensure consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design suggestion
2 participants