Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design suggestion #1103

Closed
NeilGirdhar opened this issue Jul 6, 2023 · 1 comment · May be fixed by #1104
Closed

Design suggestion #1103

NeilGirdhar opened this issue Jul 6, 2023 · 1 comment · May be fixed by #1104

Comments

@NeilGirdhar
Copy link
Contributor

NeilGirdhar commented Jul 6, 2023 •
edited

I'm just starting to use Orion. Looks like a very useful tool! One suggestion: Consider having Space depend on sorteddictionary, and use composition over inheritance.

(Also, Python dictionaries are ordered, so you ordering by name might not be that important if all you want is for the ordering to be consistent between runs.)
@bouthilx
Copy link
Member

bouthilx commented Jul 6, 2023

Thanks for the suggestion! The names were indeed sorted as a simple solution to keep ordering consistent between runs for python <=3.5. Now that we do not support 3.5 we could indeed remove this. I'm happy to help if you'd be interested in making a PR. :)

@NeilGirdhar NeilGirdhar mentioned this issue Jul 6, 2023
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Order Space by insertion order NeilGirdhar/orion
2 participants
@NeilGirdhar @bouthilx