Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Commit

Permalink
Merge pull request #492 from mcottontensor/setting_option_fix
Browse files Browse the repository at this point in the history
Setting option fix
  • Loading branch information
mcottontensor committed Feb 20, 2024
2 parents 672397e + caddb00 commit 88d82e1
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 3 deletions.
42 changes: 42 additions & 0 deletions .github/workflows/run-signalling-tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: Run signalling tests

on:
workflow_dispatch:
push:
branches: ['signalling_tester']
paths: ['SignallingWebServer/**']
pull_request:
branches: ['signalling_tester']
paths: ['SS_Test/**']

jobs:

build:
runs-on: ubuntu-latest
defaults:
run:
working-directory: ./

permissions:
contents: write

steps:
- name: "Checkout source code"
uses: actions/checkout@v3

- uses: actions/setup-node@v3
with:
node-version: '18.x'
registry-url: 'https://registry.npmjs.org'

- name: Run signalling server
working-directory: ./SignallingWebServer
run: ./platform_scripts/bash/run_local.sh &

- name: Install library deps
working-directory: ./SS_Test
run: npm ci

- name: Run frontend lib tests
working-directory: ./SS_Test
run: npm run start
4 changes: 2 additions & 2 deletions Frontend/library/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Frontend/library/src/Config/SettingOption.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class SettingOption<
// eslint-disable-next-line @typescript-eslint/no-empty-function
defaultOnChangeListener: (changedValue: unknown, setting: SettingBase) => void = () => { /* Do nothing, to be overridden. */ }
) {
super(id, label, description, [defaultTextValue], defaultOnChangeListener);
super(id, label, description, defaultTextValue, defaultOnChangeListener);

this.options = options;
const urlParams = new URLSearchParams(window.location.search);
Expand Down

0 comments on commit 88d82e1

Please sign in to comment.