Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forceMultiPart TypeScript Definition for Options #30

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

KidSysco
Copy link
Contributor

@KidSysco KidSysco commented Nov 2, 2023

The forceMultiPart option is not available in TS, due to it missing from the definitions.

I added it to the FormMethodOptions definition, and I added two tests to help ensure the defs are working properly.

Let me know if you need any further changes to this PR and I will support it.

Fastify rocks!

Thank you.

Copy link
Owner

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh gosh - I forgot to add it to the readme! Would you be so kind to add it too?

@KidSysco
Copy link
Contributor Author

KidSysco commented Nov 2, 2023

A small bit of documentation has been added to what is there. It is not super verbose. I could certainly talk much more about it if needed. lol

But I have a feeling you want to keep it simple.

Let me know if you need anything else.

@KidSysco
Copy link
Contributor Author

KidSysco commented Nov 6, 2023

Hi @Eomm,

I hope you're doing well. I wanted to check in on the pull request I submitted regarding the TypeScript definitions. I understand that maintainers are usually quite busy, and I appreciate your time and effort in maintaining the project.

It has been open for five days, and I'm eager to contribute and make this project even better. If there are any changes or additional information you need from me, please don't hesitate to let me know. I'm more than willing to make any necessary adjustments.

Thank you for your consideration, and I look forward to your feedback when you have the time.

Best regards,
KidSysco

Copy link
Owner

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A ping was enough 😂

image

@Eomm Eomm merged commit 18f0b04 into Eomm:main Nov 6, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants