New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restructure types #101

Open

matthyk wants to merge 2 commits into Eomm:main from matthyk:types-restructuring

Contributor

matthyk commented Feb 8, 2024

This PR aims to discuss this idea. I have 2 motivations for the restructuring:

Previously, the types used internally were not exported. I think it is much more convenient if all types are simply exported, otherwise you have to stupidly rebuild the types for a TypeScript project
I had strange problems registering the fastifyOverview plugin in my TypeScript project. After this restructuring I had no more problems

I have followed the example of other Fastify plugins for the restructuring. See for example @fastify/postgres or @fastify/mongodb.

matthyk added 2 commits

February 9, 2024 00:01


          restructure types

7edb37a


          Merge branch 'main' into types-restructuring

64026c0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment