Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped minimum and latest Python version for mvp-rapid #786

Draft
wants to merge 2 commits into
base: feature/mvp-rapid
Choose a base branch
from

Conversation

ens-sb
Copy link
Contributor

@ens-sb ens-sb commented May 14, 2024

Description

Related JIRA tickets:

Overview of changes

Change 1

Bumped minimum and latest Python version for mvp-rapid.

Change 2

Updated ensembl-py dependency.


For code reviewers: code review SOP

Also updated ensembl-py dependency.
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.33%. Comparing base (777c5cd) to head (82bb617).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           feature/mvp-rapid     #786      +/-   ##
=====================================================
+ Coverage              58.67%   59.33%   +0.66%     
=====================================================
  Files                    197      217      +20     
  Lines                  22014    22752     +738     
  Branches                3487     3487              
=====================================================
+ Hits                   12916    13500     +584     
- Misses                  7992     8146     +154     
  Partials                1106     1106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twalsh-ebi twalsh-ebi self-requested a review May 16, 2024 15:05
Copy link
Contributor

@twalsh-ebi twalsh-ebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the PR itself look good to me, but I'd suggest to also update the Python version here and here.

@ens-sb ens-sb marked this pull request as draft June 7, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants