Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tree refinement and constraint topology in species tree pipeline #784

Merged
merged 3 commits into from
May 20, 2024

Conversation

ens-sb
Copy link
Contributor

@ens-sb ens-sb commented May 10, 2024

Description

There is a need for specifying a topology constraint in the pipeline in order to allow adding new genomes to an existing topology while keeping it fixed.

Related JIRA tickets:

Overview of changes

Change 1

Using the astral tree as starting topology instead of constraint in the protein branch length calculation step.

Change 2

Added option to specify constraining topology as a newick file.

Testing

The pipeline was tested on the vertebrates 112 division. The run finished in 5 hours.


For code reviewers: code review SOP

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.25%. Comparing base (3b6ba42) to head (18f0e66).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #784      +/-   ##
==========================================
- Coverage   60.27%   60.25%   -0.02%     
==========================================
  Files         195      195              
  Lines       22412    22412              
  Branches     3618     3618              
==========================================
- Hits        13509    13505       -4     
- Misses       7698     7699       +1     
- Partials     1205     1208       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jitender-ebi jitender-ebi merged commit e164794 into Ensembl:main May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants