Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore alt host registry config #780

Conversation

twalsh-ebi
Copy link
Contributor

@twalsh-ebi twalsh-ebi commented Apr 22, 2024

Though Compara pipelines almost always access core databases on vertannot-staging, once in a while it may be necessary to configure the Compara registry to use production staging servers.

In anticipation of that, this PR updates Compara registries with alternative host config for production staging servers.

These changes were tested by running flag_core_issues.pl on updated registries on the release/112 branch.

All checks passed, except for Plants, which flagged the following issue:

    #   Failed test 'oryza_sativa_ir64_core_59_112_1 release'
    #   at /hps/software/users/ensembl/compara/twalsh/repos/e112/ensembl-compara/scripts/production/flag_core_issues.pl line 247.
    #          got: '111'
    #     expected: '112'
    # Looks like you failed 1 test of 272.
#   Failed test 'Check core database metadata (plants)'
#   at /hps/software/users/ensembl/compara/twalsh/repos/e112/ensembl-compara/scripts/production/flag_core_issues.pl line 253.
# Looks like you failed 1 test of 12.

For code reviewers: code review SOP

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.25%. Comparing base (2b56bcf) to head (728e945).

Additional details and impacted files
@@             Coverage Diff              @@
##           release/113     #780   +/-   ##
============================================
  Coverage        60.25%   60.25%           
============================================
  Files              195      195           
  Lines            22420    22420           
  Branches          3619     3619           
============================================
+ Hits             13509    13510    +1     
  Misses            7704     7704           
+ Partials          1207     1206    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thiagogenez thiagogenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@twalsh-ebi twalsh-ebi force-pushed the feature/restore_alt_host_config branch from eb8a611 to b61806a Compare May 8, 2024 13:54
@twalsh-ebi twalsh-ebi force-pushed the feature/restore_alt_host_config branch from b61806a to 728e945 Compare May 16, 2024 18:33
@Simarpreet-Kaur-Bhurji Simarpreet-Kaur-Bhurji merged commit a31ace4 into Ensembl:release/113 May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants