New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update toggles jquery ui #112
Open
kipraske
wants to merge
11
commits into
Enclavely:master
Choose a base branch
from
kipraske:feature/update-toggles-jquery-ui
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/update toggles jquery ui #112
kipraske
wants to merge
11
commits into
Enclavely:master
from
kipraske:feature/update-toggles-jquery-ui
Commits on Mar 9, 2017
-
Merge pull request #1 from andrew-worsfold/master
Updating fork to master 3/9/2017
Configuration menu - View commit details
-
Copy full SHA for f129a80 - Browse repository at this point
Copy the full SHA f129a80View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2395e1 - Browse repository at this point
Copy the full SHA e2395e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e56897 - Browse repository at this point
Copy the full SHA 2e56897View commit details -
Oh actually toggles = accordions.
Alright this isn't quite working as we expect. We need a HTML structure of... ``` accordion-wrapper h3 div h3 div h3 div ``` Here is what we have ``` accordion-wrapper toggle-wrapper h3 div toggle-wrapper h3 div ```
Configuration menu - View commit details
-
Copy full SHA for e576df1 - Browse repository at this point
Copy the full SHA e576df1View commit details
Commits on Mar 10, 2017
-
Successfully hooked up toggles jQuery UI for toggles
We just needed to define the header option for the toggles
Configuration menu - View commit details
-
Copy full SHA for 4ff6fa1 - Browse repository at this point
Copy the full SHA 4ff6fa1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61edb4a - Browse repository at this point
Copy the full SHA 61edb4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for eaf5777 - Browse repository at this point
Copy the full SHA eaf5777View commit details
Commits on Apr 10, 2017
-
Missing Link: Event listeners on toggles working again
Turns out I needed to use onInitialize or the built in event listeners would totally not work. In order to get the backend canvas working we need those events like onChildChange etc to reinitialize the accordion, and to get those events we needed to go though the right channels
Configuration menu - View commit details
-
Copy full SHA for 774dcec - Browse repository at this point
Copy the full SHA 774dcecView commit details
Commits on Apr 12, 2017
-
Configuration menu - View commit details
-
Copy full SHA for c21404f - Browse repository at this point
Copy the full SHA c21404fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7855212 - Browse repository at this point
Copy the full SHA 7855212View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7b85a2 - Browse repository at this point
Copy the full SHA f7b85a2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.