Updated to 1.20 and did some clean up work #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tching to a redirect inject for better compatibility)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi i updated the mod to 1.20 and in the process discovered some stuff that could be cleaned up like an unused dependency on the fabric api, a client initializer even though this only uses mixin, an unneeded "remappedSrc" directory and a n in practice empty "suggests" in the fabric.mod.json.
Also discovered that this was originally using an override mixin. Which is not needed here and can lead to compatibility issues with other mods. I switched it out for a redirect directly on the LivingEntity.getDamageTiltYaw() method instead.
Added myself as an author though i don't mind if you want to take me off again
(this may constitute a mod version update depending on how you want to do your versioning. I left it as it is for now)