-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group agg rework #1741
base: main
Are you sure you want to change the base?
Group agg rework #1741
Conversation
…oup aggregate in general
…rness into group-agg-rework
@haileyschoelkopf I've only added the |
class GroupConfig(dict): | ||
group: Optional[Union[str, list]] = None | ||
aggregate_metric: Optional[str] = False | ||
aggregate_fn: Optional[str] = "mean" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aggregate fn being defined explicitly is good, I think we also need to try to be careful of how tasks with (multiple) filters interact with groups.
Currently, if two tasks have filters with different names, a group can't aggregate those correctly. We may want to have groups, for each metric they'll report, expressly define, for each subtask, what metric and what filter to include in the aggregation.
…valuation-harness into group-agg-rework
group_config
will need to be defined in the yaml that consists ofaggregate_metric
(True/False, default False) andweight_by_size
(True/False, default False).task_id
inConfigurableGroup
andConfigurableTask
to be used as identifier in lieu of task name/group name.