libplugin: show default option values #7306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. sql's dev-sqlfilename should be registered as a dev option. 2. bcli's timeout is an integer, not a string. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Serves as an example, but also shows a quirk which we fix in the next patch. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This means we can see the values in listconfigs, even if we haven't set them yet. In particular, we now see the following: * autoclean-cycle.value_int=3600 * bitcoin-rpcclienttimeout.value_int=60 * bitcoin-retry-timeout.value_int=60 * funder-max-their-funding.value_str=4294967295sat * funder-per-channel-min.value_str=10000sat * funder-reserve-tank.value_str=0sat * funder-fund-probability.value_int=100 Changelog-Changed: plugins: libplugin now shows plugin option default values (where they're non-trivial) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
| struct amount_sat *sats) | ||
| { | ||
| /* We do not expose raw numbers for sats fields: raw numbers | ||
| * in our interface means MSAT! */ |
There was a problem hiding this comment.
Good call. It's one thing for the user to set these parameters in the config, but another thing to consume them here. It might be nice if we could enforce a suffix/formatting on non-default configs as well.
endothermicdev
approved these changes
May 15, 2024
There was a problem hiding this comment.
Nice changes. I didn't realize these weren't already populated.
ACK 7cba9f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libplugin didn't have a way of showing defaults, which are often informative. This means they don't show up in listconfig (unless actually set) which surprised me.
This fixes that, so you can have an optional routine to show the value when you register a plugin. This means you now see the following new values in listconfig in a default configuration: