Autoclean for giant nodes #7298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use modern-style iterators: this can be huge and we will run out of memory! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Removed: JSON-RPC: `autocleaninvoice` command (deprecated v22.11, EOL v24.02) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We're about to make this a more complex struct, so introducing a new_clean_info() function unifies the code paths. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
There are really three subsystems: invoices, forwards and sendpays, each of which has two variants we care about (successes and failures). If we split the code that way, we can extract the core differences in each of these cases and share most of the logic. It's a bit awkward to iterate over each "subsystem" in the JSON parameter sense, so we have some iteration code to do that where we need to. The result is going to be much easier to paginate! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This is crude, handing a raw JSON string, but it works. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We can filter down to only the list* fields we need. In the case of a node with 1M forwards, this reduces listforwards time from 5 seconds to 4 seconds. It will also reduce memory consumption. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
listforwards on a large node can easily run out of memory. Sip, don't gulp! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/autoclean-giant-node
branch
from
b7bfa88
to
2a8065e
Compare
There was a problem hiding this comment.
We should remove also the docs
plugins/autoclean.c
Outdated
Comment on lines
21
to
22
| #define NUM_SUBSYSTEM_TYPES (INVOICES + 1) | ||
| }; |
There was a problem hiding this comment.
uh I did not know about this! looks amazing!
niftynei
reviewed
May 14, 2024
There was a problem hiding this comment.
This was really fun to read through.
Notably, the counter is now off in test_autoclean (predates this change).
> assert l3.rpc.autoclean_status()['autoclean']['expiredinvoices']['cleaned'] == 3
FAILED tests/test_plugin.py::test_autoclean - assert 5 == 3
Really nice usage of filter and the pagination APIs imo!!
| @@ -88,20 +91,23 @@ static const struct subsystem_ops subsystem_ops[NUM_SUBSYSTEM_TYPES] = { | |||
| { {"succeededforwards", "failedforwards"}, | |||
| "listforwards", | |||
| "forwards", | |||
| "\"in_channel\":true,\"in_htlc_id\":true,\"resolved_time\":true,\"received_time\":true,\"status\":true", | |||
There was a problem hiding this comment.
oh you weren't joking about hacky!
| @@ -455,6 +455,9 @@ bool plugin_developer_mode(const struct plugin *plugin); | |||
| #define plugin_option_dev(name, type, description, set, arg) \ | |||
| plugin_option_((name), (type), (description), (set), (arg), true, NULL, NULL, false) | |||
|
|
|||
| #define plugin_option_dev_dynamic(name, type, description, set, arg) \ | |||
There was a problem hiding this comment.
nit: should be its own commit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autoclean cannot handle giant nodes:
There are improvements across the board, but the real win comes from only listing 10,000 entries at a time.