Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry: Use non-package mode #7286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ErikDeSmedt
Copy link
Contributor

Since poetry=1.8.0 there is a non-package mode. This can be used to
create pyproject.toml files that are only used to track dependencies.

Performing poetry install in the project-root with a recent version of poetry
is currently generating a warning which will become an error in the
future.

Setting package-mode=false makes this error go away.

A side-effect is that the name, version and description in the
pyproject.toml-file will be ignored. Keeping the parameters in the
pyproject.toml file ensures it will still work for developers who are
using poetry<1.8.0.

Since `poetry=1.8.0` there is a non-package mode. This can be used to
create `pyproject.toml` files that are only used to track dependencies.

Performing `poetry install` in the project-root with a recent version of `poetry`
is currently generating a warning which will become an error in the
future.

Setting `package-mode=false` makes this error go away.

A side-effect is that the `name`, `version` and `description` in the
`pyproject.toml`-file will be ignored. Keeping the parameters in the
`pyproject.toml` file ensures it will still work for developers who are
using `poetry<1.8.0`.
Copy link
Member

@cdecker cdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK eb10287

@endothermicdev
Copy link
Collaborator

This will be nice. It didn't seem compatible with poetry < 1.8.0 though. At least with 1.7.1 I got:

The Poetry configuration is invalid:
  - Additional properties are not allowed ('package-mode' was unexpected)

Let's tag this for 24.08 to allow a grace period.

@endothermicdev endothermicdev added this to the v24.08 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants