Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msggen: add multiwithdraw method #7271

Closed

Conversation

daywalker90
Copy link
Contributor

nothing special, adds:

  • multiwithdraw

@cdecker
Copy link
Member

cdecker commented Apr 24, 2024

These PRs would be much simpler to review and merge if they weren't this disjoint by the way. The way you are doing it at the moment, the .msggen.json gets reset inbetween runs, which can cause the CI to fail on master and we have to go back and refill them in.

Can you maybe create 5-method chunks? That'd also cut down on the reviewing overhead (I get notified for every single update to any of these PRs, which de-sensitivizes reviewers to notifications, and stuff gets lost in the torrent of notifications).

@cdecker
Copy link
Member

cdecker commented Apr 24, 2024

Keep the changes to one method per commit, even when clustering, otherwise we lose the nice collation of manual changes and derived changes.

@cdecker
Copy link
Member

cdecker commented Apr 24, 2024

Also, CI resources aren't free, so let's try to preserve them as much as possible, even if it is GH footing the bill, we should be respectful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants