Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings/rust: upgrade bindgen version #4983

Merged
merged 2 commits into from Jul 31, 2023

Conversation

atmaxinger
Copy link
Contributor

Basics

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add them to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
    • fix the CI itself (or rebase if already fixed)
  • The PR is rebased with current master.

Checklist

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation (see Documentation Guidelines)
  • I fixed all affected decisions (see Decision Process)
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if everything is done and no further pushes are planned by you.

@atmaxinger atmaxinger linked an issue Jul 30, 2023 that may be closed by this pull request
Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atmaxinger Except of the Changelog this should afaik be everything. I'll try to publish it.

@atmaxinger
Copy link
Contributor Author

atmaxinger commented Jul 31, 2023

@markus2330 I've updated the Elektra changelog. Is there also another changelog for Rust somewhere?

@markus2330 markus2330 merged commit 20b90e0 into ElektraInitiative:master Jul 31, 2023
13 of 17 checks passed
@markus2330
Copy link
Contributor

No, only in the main Changelog. Thx for the fix!

@markus2330
Copy link
Contributor

I published Elektra 0.10.0 elektra and elektra-sys. After the release I'll publish 0.11.0. (@fel115)

@atmaxinger published_Cargo.toml are not updated, they should be updated, too. (with version pump to 0.11.0)

@fel115
Copy link

fel115 commented Aug 1, 2023

I published Elektra 0.10.0 elektra and elektra-sys. After the release I'll publish 0.11.0. (@fel115)

@atmaxinger published_Cargo.toml are not updated, they should be updated, too. (with version pump to 0.11.0)

What's the difference between published_Cargo.toml and Cargo.toml.in? If I now use elektra-version 0.10.0 I still get this error. Is there an option to use the Cargo.toml.in file instead of the published version ?

@markus2330
Copy link
Contributor

@fel115 Cargo.toml.in is used for CMake (the build system), published_Cargo.toml is only documentation for what was used for publishing.

I published with changes as shown in #4985. Is there anything else I should change for the 0.11.0 release?

@fel115
Copy link

fel115 commented Aug 3, 2023

@markus2330 for some reason I still get this conflict. I changed the elektra version to elektra = { version = "0.10.0", features = ["pkg-config"] }, but the error message still says: ... which satisfies dependency `bindgen = "^0.50.0" of package elektra-sys v0.9.1. I don't know why elektra-sys v0.9.1 is still in use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo.toml change bindgen version
3 participants